fix reward distributor interval delay bug #891
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the reward distribution contract currently suffers a bug where reward distribution intervals are delayed each time a voting power change occurs.
this is due to the fact that integer division is used to make it so that only increments of the linear emission rate duration are distributed. when a voting power change occurs before one interval has passed, it calculates 0 new rewards distributed and updates the last updated timestamp, which effectively restarts the interval timer.
for example, if you distribute 100 tokens per hour:
this PR fixes it so that it uses decimal math when counting the intervals that have passed since the last update in order to update the rewards distributed.
this also adds a force withdraw execution message to allow the contract owner to recover locked funds, since the delayed funds are likely stuck in the contract.
recover delayed/locked rewards
i think the ideal way to remedy this is:
this way the state should be reset to account for the pending rewards that were allegedly distributed, and you can manually withdraw any funds beyond that amount before restarting and refunding.